Skip to content

Restore re-execution middleware in templates. #63005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2025

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 30, 2025

After offline discussion with @javiercn, the decision about temporary disabling the job that is using the old version of packages was made. Detailed issue description: #62851.

This PR:

  • Restores the middleware setup in the templates
  • Disables the job that was failing with the new name of parameter error (The best overload for 'UseStatusCodePagesWithReExecute' does not have a parameter named 'createScopeForStatusCodePages').

@github-actions github-actions bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 30, 2025
@ilonatommy ilonatommy closed this Jul 30, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc1 milestone Jul 30, 2025
@ilonatommy ilonatommy reopened this Aug 6, 2025
@ilonatommy ilonatommy requested a review from javiercn August 6, 2025 09:23
@ilonatommy ilonatommy marked this pull request as ready for review August 6, 2025 11:59
@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 11:59
@ilonatommy ilonatommy requested review from wtgodbe and a team as code owners August 6, 2025 11:59
@ilonatommy ilonatommy self-assigned this Aug 6, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the status code pages re-execution middleware setup in Blazor Web templates that was previously disabled due to a parameter name change issue. The middleware configuration uses the new parameter name createScopeForStatusCodePages to ensure proper scope creation for status code handling.

Key changes:

  • Restores UseStatusCodePagesWithReExecute middleware configuration in Blazor templates
  • Temporarily disables a failing CI job that was using old parameter names
  • Updates both main Program.cs files to include the middleware with the correct parameter syntax

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Program.cs Adds status code pages middleware with re-execution to "/not-found" path
src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Program.Main.cs Adds the same middleware configuration in the main program variant
.azure/pipelines/ci-public.yml Temporarily disables a CI job that fails with the old parameter naming

@ilonatommy ilonatommy added area-blazor Includes: Blazor, Razor Components and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Aug 6, 2025
@ilonatommy ilonatommy merged commit 828955c into dotnet:main Aug 6, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants