-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Restore re-execution middleware in templates. #63005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restores the status code pages re-execution middleware setup in Blazor Web templates that was previously disabled due to a parameter name change issue. The middleware configuration uses the new parameter name createScopeForStatusCodePages
to ensure proper scope creation for status code handling.
Key changes:
- Restores
UseStatusCodePagesWithReExecute
middleware configuration in Blazor templates - Temporarily disables a failing CI job that was using old parameter names
- Updates both main Program.cs files to include the middleware with the correct parameter syntax
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Program.cs |
Adds status code pages middleware with re-execution to "/not-found" path |
src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Program.Main.cs |
Adds the same middleware configuration in the main program variant |
.azure/pipelines/ci-public.yml |
Temporarily disables a CI job that fails with the old parameter naming |
After offline discussion with @javiercn, the decision about temporary disabling the job that is using the old version of packages was made. Detailed issue description: #62851.
This PR:
The best overload for 'UseStatusCodePagesWithReExecute' does not have a parameter named 'createScopeForStatusCodePages'
).