Deoptimize the exceptional cases in favor of optimal path #62997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the state persistence flow by eliminating redundant dictionary lookups in the success path. Instead of checking for key existence with ContainsKey followed by Add, it directly uses TryAdd which atomically checks and adds the key-value pair.
- Replaces the two-step
ContainsKey+Addpattern with singleTryAddoperations - Reduces dictionary lookups from two to one in the success path
- Maintains the same exception behavior for duplicate keys
maraf
approved these changes
Aug 11, 2025
javiercn
approved these changes
Aug 11, 2025
|
/azp run aspnetcore-always-green |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/ba-g failure is not from recent build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid an extra lookup in the fastpath at the expense of potentially a lot of work