Add PQC certificate support for HTTPS #62866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we try to get this in for RC1? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Post-Quantum Cryptography (PQC) certificates in HTTPS configuration by supporting ML-DSA and SLH-DSA signature algorithms alongside existing RSA and ECDSA support. The implementation includes both certificate loading functionality and comprehensive test coverage.
Key changes include:
- Added PQC certificate support in the certificate configuration loader with OID mappings for ML-DSA and SLH-DSA variants
- Replaced hardcoded test certificates with dynamic generation to support multiple signature algorithms
- Enhanced test coverage to validate PQC certificate loading with both encrypted and unencrypted keys
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Shared/TestCertificates/https-*.pem and https-*.key |
Removed hardcoded RSA and ECDSA test certificates to be replaced with dynamic generation |
src/Servers/Kestrel/Core/src/Internal/Certificates/CertificateConfigLoader.cs |
Added PQC algorithm support with OID mappings and import methods for ML-DSA and SLH-DSA |
src/Servers/Kestrel/Kestrel/test/KestrelConfigurationLoaderTests.cs |
Refactored tests to dynamically generate certificates for multiple algorithms including PQC variants |
BrennanConroy
approved these changes
Aug 14, 2025
| } | ||
| else | ||
| { | ||
| // For all other algorithms, we generate the certificate and key dynamically, saving them |
DeagleGross
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PQC certificate support for HTTPS
Opening initially as a draft:
Note that, as of the time of writing, a Windows Insider Build (Canary) is required in order for the ML-DSA tests to pass.
Fixes #62030