-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Add support for .slnx file exclusion in BaselineTest #62767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This update introduces a new condition to the `relativePath` checks in `BaselineTest.cs`. The code now excludes files that end with the `.slnx` extension, enhancing the filtering of project-related file types and directories during processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for excluding .slnx
files in the BaselineTest filtering logic. The .slnx
extension represents a new solution file format, and this change ensures these files are properly filtered out during template testing alongside other project-related files.
Key Changes
- Added
.slnx
file extension to the exclusion list in BaselineTest filtering logic
@marcominerva Per @javiercn's comment in the issue, we're not actually exercising this path since none of the templates use slnx files at the moment. While I'm not opposed to a proactive change, it might be helpful to use slnx files in the templates as well as part of this change. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
This update introduces a new condition to the
relativePath
checks inBaselineTest.cs
. The code now excludes files that end with the.slnx
extension, enhancing the filtering of project-related file types and directories during processing.Fixes #62753