Refs #36520 -- Only passed header value for parsing on multi-part forms #19757
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing should only be done on the value. The implementation happens to work, but shouldn't depend on that working.
|
@nessita as mentioned on ticket-36520. There aren't any new tests to cover this, but the existing suite still passes, which is a good sign! |
nessita
reviewed
Aug 21, 2025
| name, value = main_value_pair.split(":", 1) | ||
| name, value_with_params = line.decode().split(":", 1) | ||
| name = name.strip().lower() | ||
| value, params = parse_header_parameters(value_with_params.lstrip(" ")) |
There was a problem hiding this comment.
What's the need for the lstrip? no test fails if we remove it 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
Semi-related to ticket-36520
Branch description
Parsing should only be done on the value. The implementation happens to work, but shouldn't depend on that working.
Checklist
mainbranch.