Fixed #36560 -- Prevented UpdateCacheMiddleware from caching responses with Cache-Control 'no-cache' or 'no-store'. #19748
+26
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
e9bf4fc to
0527f51
Compare
|
Thank you! --- a/tests/cache/tests.py
+++ b/tests/cache/tests.py
@@ -2731,16 +2731,17 @@ class CacheMiddlewareTest(SimpleTestCase):
)
cache.clear()
- def test_cached_control_private_not_cached(self):
- """Responses with 'Cache-Control: private' are not cached."""
- view_with_private_cache = cache_page(3)(
- cache_control(private=True)(hello_world_view)
- )
- request = self.factory.get("/view/")
- response = view_with_private_cache(request, "1")
- self.assertEqual(response.content, b"Hello World 1")
- response = view_with_private_cache(request, "2")
- self.assertEqual(response.content, b"Hello World 2")
+ def test_cached_control_not_cached(self):
+ for cc in ("private", "no-cache", "no-store"):
+ with self.subTest(cache_control=cc):
+ view_with_private_cache = cache_page(3)(
+ cache_control(**{cc: True})(hello_world_view)
+ )
+ request = self.factory.get("/view/")
+ response = view_with_private_cache(request, "1")
+ self.assertEqual(response.content, b"Hello World 1")
+ response = view_with_private_cache(request, "2")
+ self.assertEqual(response.content, b"Hello World 2")
def test_sensitive_cookie_not_cached(self): |
|
Hello @sarahboyce , the test cases have been updated. |
…s with Cache-Control 'no-cache' or 'no-store'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36560
Branch description
When the Cache-Control header is set to private, no-cache, or no-store, the response should not be cached.
Checklist
mainbranch.