Skip to content

Fixed incorrect use of "generated field" in django/forms/models.py. #19732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

Fixed incorrect use of "generated field" in django/forms/models.py. #19732

merged 1 commit into from
Aug 21, 2025
+2 −2

Conversation

cliff688
Copy link
Member

Since Django 5.0, generated field means django.db.models.GeneratedField.

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Aug 15, 2025
nessita
nessita reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cliff688, I think this clarification is worth the commit! 🌟

Added a small suggestion.

nessita
nessita approved these changes Aug 21, 2025
View reviewed changes
@nessita nessita merged commit dd15f7d into django:main Aug 21, 2025
34 checks passed
@cliff688 cliff688 deleted the disambiguate-gen-field-comment branch August 21, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessita nessita nessita approved these changes

Assignees
No one assigned
Labels
no ticket Based on PR title, no linked Trac ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cliff688 @nessita