Skip to content

Fixed #34624 - Removed edit and view options in RelatedFieldWidgetWrapper for radioselects. #18877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JaeHyuckSa
Copy link
Contributor

@JaeHyuckSa JaeHyuckSa commented Dec 2, 2024

Trac ticket number

ticket-34624

Branch description

I continued working on the PR for @allcaps.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@BSmick6
Copy link
Contributor

BSmick6 commented Dec 2, 2024

@JaeHyuckSa it looks like you're running into the same issue I was. You should rebase this branch to the main upstream branch and force push again: https://docs.djangoproject.com/en/5.1/internals/contributing/writing-code/working-with-git/#after-upstream-has-changed

@JaeHyuckSa
Copy link
Contributor Author

@JaeHyuckSa it looks like you're running into the same issue I was. You should rebase this branch to the main upstream branch and force push again: https://docs.djangoproject.com/en/5.1/internals/contributing/writing-code/working-with-git/#after-upstream-has-changed

@BSmick6 Thank you for letting me know, but it seems that a different issue is occurring than the one you mentioned.

@BSmick6
Copy link
Contributor

BSmick6 commented Dec 3, 2024

@JaeHyuckSa it looks like you're running into the same issue I was. You should rebase this branch to the main upstream branch and force push again: https://docs.djangoproject.com/en/5.1/internals/contributing/writing-code/working-with-git/#after-upstream-has-changed

@BSmick6 Thank you for letting me know, but it seems that a different issue is occurring than the one you mentioned.

Oh, interesting! I would love to find out why. I don't see why any of your changes would cause any of those errors, but I can try talking a look later this afternoon.

@sarahboyce
Copy link
Contributor

Instead of testing the redirect admin, I would refine a new admin in tests/admin_widgets/widgetadmin.py that sets radio_fields similar to the redirect admin

@JaeHyuckSa
Copy link
Contributor Author

@sarahboyce Thank you for the guidance. Sorry for the delayed response — I’ve updated the patch according to your feedback.

…pper for radioselects.

Signed-off-by: SaJH <wogur981208@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants