-
-
Notifications
You must be signed in to change notification settings - Fork 129
feat: add RateLimited gateway event #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus Jiras request
/** | ||
* @see {@link https://discord.com/developers/docs/events/gateway-events#rate-limited} | ||
*/ | ||
export type GatewayRateLimitedDispatch< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a union of concretes, not require users to pass in the op code they want imo. That said, how you'd present this is...gonna be fun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it as close as docs as possible.
Additionally, the type parameter has a default (all the valid opcodes, which is only one anyways), if that's your concern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still export aliased types for speed
Please describe the changes this PR makes and why it should be merged:
If applicable, please reference Discord API Docs PRs or commits that influenced this PR: