feat: Support select in modals #1321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Qjuh
previously requested changes
Aug 7, 2025
dc2f2ee to
42bfca7
Compare
vladfrangu
previously requested changes
Aug 7, 2025
369800e to
277fe68
Compare
Qjuh
approved these changes
Aug 7, 2025
206e07c to
a307dd1
Compare
vladfrangu
requested changes
Aug 22, 2025
| export type APIComponentInMessageActionRow = APIButtonComponent | APIStringSelectComponent; | ||
|
|
||
| /** | ||
| * @see {@link https://discord.com/developers/docs/components/reference#action-row} |
There was a problem hiding this comment.
With the addition of APIComponentInLabel, seems that is indeed correct. Or not totally correct?
We can do slap a TODO on it and optionally remove the documentation link until labels are documented. Thoughts?
| /** | ||
| * @see {@link https://discord.com/developers/docs/components/reference#action-row} | ||
| */ | ||
| export type APIComponentInModal = APIComponentInLabel | APIComponentInModalActionRow; |
There was a problem hiding this comment.
Shouldn't this be APILabelComponent | APIModalActionRowThing
There was a problem hiding this comment.
APIModalComponent above seems to be that. The naming conventions don't really seem intuitive, but it is what it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/222078108977594368/1402934237358985246