Owlapy 1.3.3 #486
Owlapy 1.3.3 #486
Conversation
examples/retrieval_eval.py
Outdated
| @@ -86,9 +86,9 @@ def execute(args): | |||
| object_properties = sorted({i for i in symbolic_kb.get_object_properties()}) | |||
|
|
|||
| # (3.1) Subsample if required. | |||
| if args.ratio_sample_object_prop: | |||
There was a problem hiding this comment.
Prop is an abbreviation of property. Why do we need to use prob?
There was a problem hiding this comment.
In the file retrieval_eval_under_incomplete.py there is the same argument but with the name ratio_sample_object_prob. They both have the same description and are both numerical values. One of them has to be wrong right? For a moment i thought this was related to probability (since it was a number), that is why I made this change but now that you mentioned it, it has to be incorrect in the retrieval_eval_under_incomplete.py file.
There was a problem hiding this comment.
Let's use ratio_sample_object_prop, where p stands for property
examples/retrieval_eval.py
Outdated
| @@ -271,7 +272,7 @@ def get_default_arguments(): | |||
| parser.add_argument("--gamma", type=float, default=0.9) | |||
| parser.add_argument("--seed", type=int, default=1) | |||
| parser.add_argument("--ratio_sample_nc", type=float, default=0.2, help="To sample OWL Classes.") | |||
| parser.add_argument("--ratio_sample_object_prop", type=float, default=0.1, help="To sample OWL Object Properties.") | |||
| parser.add_argument("--ratio_sample_object_prob", type=float, default=0.1, help="To sample OWL Object Properties.") | |||
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| branches: | |||
| - master | |||
| - develop | |||
There was a problem hiding this comment.
Why do we need to make this change?
There was a problem hiding this comment.
That is done in order to not publish the documentation changes while developing. This way the documentation gets published whenever we do a new release (so when we merge with master) and the documentation stays consistent to the latest version of our library. We also specify the version in the documentation so it wont be correct to have the documentation changed while still developing features that are not out yet.
If there is a error in the docs or something that has to be chaged quickly we can use the documentation branch.
retrieval_eval.pyandretrieval_eval_under_incomplete.pydocumentationbranch for typo fixing etc.