Skip to content

[DWDS] prepare for 24.4.0+1 hotfix release #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2025
Merged

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Aug 22, 2025

Includes the following change:

[ DWDS ] Disconnect non-DDS clients when DDS connects (#2671)
The native VM service disconnects all non-DDS clients when DDS connects
in order to keep state consistent. DWDS was never configured to work
this way and, instead, would not let DDS connect if there were already
existing clients.

This is fine most of the time, as DDS is typically the first client, but
in cases where multiple DDS instances attempt to start at once (e.g., a
simultaneous flutter run and flutter attach), this inconsistency
prevents tools from falling back to using an already connected DDS
instance, as seen in flutter/flutter#171758.

Fixes #2399

This hotfix is required for a CP to Flutter 3.35 to resolve flutter/flutter#171758.

bkonyi added 2 commits August 22, 2025 12:53
The native VM service disconnects all non-DDS clients when DDS connects
in order to keep state consistent. DWDS was never configured to work
this way and, instead, would not let DDS connect if there were already
existing clients.

This is fine most of the time, as DDS is typically the first client, but
in cases where multiple DDS instances attempt to start at once (e.g., a
simultaneous `flutter run` and `flutter attach`), this inconsistency
prevents tools from falling back to using an already connected DDS
instance, as seen in flutter/flutter#171758.

Fixes #2399
@bkonyi bkonyi requested a review from srujzs August 22, 2025 16:56
@bkonyi bkonyi changed the base branch from main to 24.4.0+1-hotfix August 22, 2025 17:00
@bkonyi bkonyi merged commit 6ec171b into 24.4.0+1-hotfix Aug 22, 2025
36 of 44 checks passed
@bkonyi bkonyi deleted the 24.4.0+1_hotfix branch August 22, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tool_crash] ExistingDartDevelopmentServiceException yieldControlToDDS should disconnect non-DDS clients
2 participants