Always add binops to methoddef #5868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the user-provided version can be looked up by e.g. self.__add__ skipping the Cython-generated dispatch wrapper and matching python semantics. Fixes cython#5863
da-woods
commented
Nov 25, 2023
da-woods
commented
Nov 26, 2023
|
I'd like to get this merged for the next 3.0.x release - I think it does improve the usability of the new binops. (So I'll merge it in a week or so unless there's any objections) |
Changed my mind on 3.0.x - I'm merging it into 3.1 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the user-provided version can be looked up by e.g.
self.__add__skipping the Cython-generated dispatch wrapper and matching python semantics.Fixes #5863