Skip to content

improve formats UX (markup and styling), add details/summary to mediums and formats #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 25, 2025
Merged

improve formats UX (markup and styling), add details/summary to mediums and formats #565

merged 10 commits into from
Mar 25, 2025

Conversation

@possumbilities
Copy link
Contributor

@possumbilities possumbilities commented Feb 10, 2025 •
edited
Loading

Description

  • fixes duplicate input name error
  • strip html from inputs in Attribution Details area.
  • adds rough read-only fields to the Attribution Details area (trying for now, may rework or change/remove later)
  • wraps the Mark formats section in <details>, and moves towards a collapsible section, rather than tabs more better cross-viewport UX and to simplify the implementation more (tabs don't have a native element implementation and often assume a detachment of "title" and "body" that can lead to odd semantics)
  • adds baseline responsiveness to build from

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@possumbilities possumbilities self-assigned this Feb 10, 2025
@possumbilities possumbilities changed the title add tabs ux, improve formats UX (markup and styling), Mar 4, 2025
@possumbilities possumbilities changed the title improve formats UX (markup and styling), improve formats UX (markup and styling), append dynamic read-only fields to attribution details, add open/close panel states to mark formats Mar 4, 2025
@possumbilities possumbilities changed the title improve formats UX (markup and styling), append dynamic read-only fields to attribution details, add open/close panel states to mark formats improve formats UX (markup and styling), add details/summary to mediums and formats Mar 25, 2025
@possumbilities possumbilities moved this from In progress to In review in possumbilities Mar 25, 2025
@possumbilities possumbilities marked this pull request as ready for review March 25, 2025 13:40
@possumbilities possumbilities requested review from a team as code owners March 25, 2025 13:40
@possumbilities possumbilities requested review from obulat and removed request for a team and obulat March 25, 2025 13:40
Shafiya-Heena
Shafiya-Heena approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@Shafiya-Heena Shafiya-Heena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@possumbilities possumbilities merged commit 9d8ceae into refactor Mar 25, 2025
@possumbilities possumbilities deleted the add-tabs branch March 25, 2025 13:53
@github-project-automation github-project-automation bot moved this from In review to Done in possumbilities Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shafiya-Heena Shafiya-Heena Shafiya-Heena approved these changes

@TimidRobot TimidRobot Awaiting requested review from TimidRobot

Assignees

@possumbilities possumbilities

Labels

None yet

Projects

possumbilities
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@possumbilities @Shafiya-Heena