Skip to content

Conversation

possumbilities
Copy link
Contributor

@possumbilities possumbilities commented Jan 14, 2025

Description

  • adds a <template> for each license
  • loads each license <template> based on state.props.license when known
  • cycles through various rendering pathways for the UX steps (don't show SA if ND, etc).
  • sets a state.props.cursor to track current step, and clear any selections left from a previous journey through the steps afterward.
  • correctly selects, and renders the appropriate license based on valid pathways of selection through the stepper
  • sets better defaults on various steps, so explicit decisions have to be made on steps > 0.

Technical details

  • adds additional functions to fully flesh out setting the remaining sub-items of state, tracking that and aligning both the state with the various UI elements found within the steppers, to keep them in sync along chosen pathways
  • there's definitely room for more refactoring how the functions are structured, and a few could do with better generalizations, but it works and I'm moving focus elsewhere until we get to later phases.
  • there's also room for the various use of template to be generalized more, and sub-divided into sub-templates; and an argument for full conversion to Web Components, but at this stage I don't see the benefit yet at that level of abstraction, and I'm not sure that's necessary in the final refactor either.

Next up, is rendering out the "mark you work" section, pulling relevant input data from the "attribution details" text inputs. I'll also utilize <template> here, and keep the output rendering to a minimum (likely only doing plain text formatting for now. Later formatting can be built out in later PRs.

Screenshots

two-col-rec-cc0

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@possumbilities possumbilities changed the title add baseline templates for the various license, to load dynamically in "rec area" when a matching license is found from state.current add baseline templates for the various licenses, to load dynamically in "rec area" when a matching license is found from state.current Jan 15, 2025
@possumbilities possumbilities marked this pull request as ready for review January 15, 2025 20:28
@possumbilities possumbilities requested review from a team as code owners January 15, 2025 20:28
@possumbilities possumbilities requested review from a team, obulat and zackkrida and removed request for a team, obulat and zackkrida January 15, 2025 20:28
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--exciting to see it come together!

@possumbilities possumbilities merged commit 3d280de into refactor Jan 15, 2025
@possumbilities possumbilities deleted the render-recs branch January 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants