[Fix] icon overlay issue of the close button in modal #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
This PR fixes the issue with the cc logo icon appearing of the close icon on the modals. This is largely a temporary fix.
Technical details
The issue was caused by how vocabulary handles the
.icon*
classes, which replaces icons that are not in vocabulary with the cc icon as a default.From careful inspection of the code, the modal was handled by an
app-modal
component, which was imported from the@creativecommons/vocabulary-components
npm package.Because this package is based on the vue implementation of the legacy vocabulary code, it meant that I couldn't access or edit the source component directly. Hence, I implemented a new modal component,
AppModal
which is the new wrapper for theChooserModal
component contents. This new component now has a corrected implementation of the close icon.Additional Notes
I must add that this implementation is temporary, as there is no close icon in the the vocabulary design system yet. A more permanent solution would be to;
Tests
docker compose exec chooser-node npm run test
command and observe your terminal and confirm no errors were logged.Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin