Skip to content

failing cypress tests successfully passed #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

failing cypress tests successfully passed #448

merged 3 commits into from
Mar 10, 2023

Conversation

@Cronus1007
Copy link
Member

Fixes

Fixes #447 by @Cronus1007

Description

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Cronus1007 Cronus1007 requested a review from a team as a code owner February 23, 2023 16:28
@Cronus1007
Copy link
Member Author

@possumbilities @TimidRobot The problem was arising since in order to pass the test cases for using chooser as web-components @shailee-m used getIFrame() function but if we would be running chooser as normal web app we would require cy as the running command since normally chooser cant detect iframes. I have resolved the issue. Please have a look upon the PR and recommend any changes that need to be brought in this PR.

@Neilblaze Neilblaze mentioned this pull request Feb 27, 2023
Closed
1 task
@possumbilities
Copy link
Contributor

@Cronus1007 Thank you for looking into this and submitting this PR. Initially it looks sound. I'm slating it for review and if all works out fine I'll mark approved soon! ❤️

possumbilities
possumbilities approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via Docker. All seems sounds. Thank you for correcting this!

@possumbilities possumbilities merged commit 1ab4ee6 into main Mar 10, 2023
@TimidRobot TimidRobot deleted the issue-447 branch March 11, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@possumbilities possumbilities possumbilities approved these changes

@TimidRobot TimidRobot Awaiting requested review from TimidRobot

@zackkrida zackkrida Awaiting requested review from zackkrida

@obulat obulat Awaiting requested review from obulat

Assignees

@Cronus1007 Cronus1007

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Cypress End to End Tests are failing

2 participants

@Cronus1007 @possumbilities