Skip to content

Controlling Chooser With License Icon Selections #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 27, 2019
Merged

Controlling Chooser With License Icon Selections #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b8e164c
Remove radio button controls
Jul 3, 2019
95ea28a
Add commercial uses icon
Jul 5, 2019
f8c28be
Add SA icon, still a bit buggy
Jul 5, 2019
ac04dc2
Try out new layout
Jul 7, 2019
23dacc0
Add chooser icon descriptions
Jul 10, 2019
72450a5
Get SA toggle working properly
Jul 10, 2019
42dd0a7
Get SA display toggling working
Jul 10, 2019
02d0956
Add hover shading to icons
Jul 10, 2019
7c7af67
Fix broken CSS, Fix broken chooser logic
Jul 10, 2019
820b2d9
Cleanup
Jul 17, 2019
1215a86
Play around with getting icon description to select license feature
Jul 23, 2019
1a3b0af
Merge branch 'master' into chooser-icon_selection
Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Play around with getting icon description to select license feature
  • Loading branch information
Ari committed Jul 23, 2019
commit 1215a86c616f8892aca50c9f354fd5fec9eb96e7
2 changes: 1 addition & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h1 class="title is-1">CC License Chooser</h1>
<div class="columns">
<div class="column">
<b style="margin-bottom: 5%">To change the selected license, click the icons below.</b>
<div class="columns">
<div class="columns chooser-icon-column" onclick="switch_callback('allow-commercial-switch')">
<div class="column is-narrow">
<div id="control-icon-container" class="control">
<input id="allow-commercial-switch" type="checkbox" class="css-checkbox is-commercial"
Expand Down
15 changes: 9 additions & 6 deletions src/scripts/choose-a-license.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ function set_license_link() {
* @param {object} check The HTML SA Checkbox object
*/
function sa_check_callback(check) {
console.log("Checkbox Toggled")
console.log(check.checked)
//console.log("Checkbox Toggled")
//console.log(check.checked)
app_state.chooser.inputs.share_alike = !app_state.chooser.inputs.share_alike
set_license()
}
Expand All @@ -128,10 +128,13 @@ function sa_check_callback(check) {
* @param {object} cb The HTML switch object
*/
function switch_callback(cb) {
console.log("Switch Toggled - " + cb.id)
var state = app_state.chooser.inputs
// If string is passed, id is string, else checkbox id is id
var id = typeof cb == "string" ? id = cb : id = cb.id
console.log("Switch Toggled - " + id)
state.selected_license = ""
switch (cb.id) {

switch (id) {
case "allow-adaptations-switch":
if (!cb.checked) { // If allow adaptations
console.log("Is Allow Adaptations - " + !cb.checked)
Expand Down Expand Up @@ -170,12 +173,12 @@ function toggle_license_icon(icon, is_show) {
}

function hide_sa_check() {
console.log("SA Hidden")
//console.log("SA Hidden")
document.getElementById("sa-control-container").style.display = "none"
}

function show_sa_check() {
console.log("SA Shown")
//console.log("SA Shown")
var element = document.getElementById("sa-control-container")
if (app_state.chooser.inputs.share_alike) {
element.checked = "true"
Expand Down
4 changes: 4 additions & 0 deletions src/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ h3 {
margin-bottom: 1em
}

.chooser-icon-column {
cursor: pointer;
}

input[type=checkbox].css-checkbox{ display: none; }

.css-label {
Expand Down