Skip to content

WIN32\CMAKE_FIND_LIBRARY_SUFFIXES not set properly during CPP-NETLIB_STATIC_OPENSSL build #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2019
Merged

WIN32\CMAKE_FIND_LIBRARY_SUFFIXES not set properly during CPP-NETLIB_STATIC_OPENSSL build #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
The CmakeLists.txt file in the cpp-netlib repository incorrectly sets 
the lib suffixes when building with CPP-NETLIB_STATIC_OPENSSL on a
Windows Machine. Adding an 'If (WIN32)' condition to properly set
CMAKE_FIND_LIBRARY_SUFFIXES to '.lib' on a windows machine.
  • Loading branch information
@rp1260
rp1260 committed May 28, 2019
commit d50340e62f1ba571be7daee6dd62a960f6e60507
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,11 @@ if (CPP-NETLIB_ENABLE_HTTPS)
endif()
endif()
if (CPP-NETLIB_STATIC_OPENSSL)
set(CMAKE_FIND_LIBRARY_SUFFIXES .a)
if (WIN32)
set(CMAKE_FIND_LIBRARY_SUFFIXES .lib)
else()
set(CMAKE_FIND_LIBRARY_SUFFIXES .a)
endif()
endif()
find_package(OpenSSL)
endif()
Expand Down