rust/src/compose: add --write-lockfile-to / --lockfile-strict #5412
Conversation
This was missing for `rpm-ostree compose image`
|
Hi @champtar. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Thanks for the patch!
I'm OK with this though I will note that technically lockfiles are experimental still. Though now that I look we actually ignored that here previously with a stable lockfile verb calling --ex-lockfile. Oh well.
Worth noting that future directions here will (hopefully) come out of rpm-software-management/dnf5#833
|
/override ci/prow/fcos-e2e |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I'll be playing more with OCI images this week, so I might have more patches coming soon. |
| /// Operate only on cached data, do not access network repositories | ||
| offline: bool, | ||
|
|
||
| #[clap(long, conflicts_with_all = ["lockfiles", "lockfile_strict"])] |
There was a problem hiding this comment.
Hmm, why do we add a conflict here? They can be used independently.
There was a problem hiding this comment.
If you write the lock file, you don't read it, so both lockfiles and lockfile_strict make no sense
There was a problem hiding this comment.
The output lock file is complete and describes the final package set that was composed.
Input lockfiles constrain the set of possible solutions. They may be complete or incomplete.
See e.g. https://github.com/coreos/fedora-coreos-config/blob/rawhide/manifest-lock.overrides.yaml. That's the only lockfile we feed to rpm-ostree when building rawhide currently.
There was a problem hiding this comment.
The combinations of options that make sense:
--write-lockfile-to--lockfile--lockfile --lockfile-strict
There was a problem hiding this comment.
Hmm, did you see my previous comment?
They're independent and can be used independently or together (and in fact, we use them together in cosa).
There was a problem hiding this comment.
You can read a partial lock file and write a full lock file, got it now and make sense, will send a patch shortly
This was missing for
rpm-ostree compose imageFixes #5409