compose: Support buildah too #5283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK for me this now works inside the stock buildah container to go from built container (i.e. in |
e1ab364 to
081b33a
Compare
Nooo util-linux in c9s is too old for that...ugh |
081b33a to
00713e8
Compare
00713e8 to
0269854
Compare
Prep for further work. Signed-off-by: Colin Walters <walters@verbum.org>
It's helpful for us to support build environments that only have podman, as well as those that only have buildah. They're mostly doing the same things; an abstraction over them is trivial. From this code, the only difference really is `podman create` vs `buildah from`. Signed-off-by: Colin Walters <walters@verbum.org>
Turned out I was missing skopeo. Signed-off-by: Colin Walters <walters@verbum.org>
44cf92b to
88d2ae5
Compare
Signed-off-by: Colin Walters <walters@verbum.org>
88d2ae5 to
ef4d772
Compare
|
Whee, finally got all the GHA tests to work! |
|
Jenkins failure was longstanding autoupdate flake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compose: Split off a containers_storage module
Prep for further work.
Signed-off-by: Colin Walters walters@verbum.org
compose: Support buildah too
It's helpful for us to support build environments that only have podman,
as well as those that only have buildah. They're mostly doing the same
things; an abstraction over them is trivial. From this code, the only
difference really is
podman createvsbuildah from.Signed-off-by: Colin Walters walters@verbum.org
compose: Add some error prefixing
Turned out I was missing skopeo.
Signed-off-by: Colin Walters walters@verbum.org