Skip to content

override replace: allow not freeze for --from option #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

override replace: allow not freeze for --from option #3164

wants to merge 1 commit into from

Conversation

@Razaloc
Copy link
Contributor

@Razaloc Razaloc commented Oct 10, 2021

override replace --experimental --from KIND=NAME do not pin the
overrided package allowing updates

Signed-off-by: Rafael G. Ruiz llerrak@hotmail.com

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2021

Hi @Razaloc. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Razaloc
Copy link
Contributor Author

Razaloc commented Oct 10, 2021 •
edited
Loading

work in progress. Still figuring out how deploy_transaction_execute works and how to trigger this option properly from src/app/rpmostree-override-builtins.cxx@jlebon

@jlebon
Copy link
Member

jlebon commented Oct 12, 2021

Hey @Razaloc, check out #3125, which is a recent PR that plumbs through a new switch for an idea of how everything fits together. In the case of repo overrides, some of that work has already been done on the client side as you know, so I think it'd mostly require work on the daemon side.

@Razaloc
Copy link
Contributor Author

Razaloc commented Oct 19, 2021 •
edited
Loading

@jlebon I've tried to adapt the related changes of that PR to this one, but It's still work in progress. If you notice some part of it that is not necessary or wrong please let me know.

@Razaloc Razaloc force-pushed the notfreeze branch 2 times, most recently from 582201f to 1f43b1e Compare November 17, 2021 14:46
@Razaloc
override replace: allow not freeze for --from option
73d62cb 
`override replace --experimental --from KIND=NAME` do not pin the
overrided package allowing updates

Signed-off-by: Rafael G. Ruiz <llerrak@hotmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2022

@Razaloc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress needs-ok-to-test needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Razaloc @jlebon