Update to TypeScript 5.9; Uint8Array to Uint8Array<ArrayBuffer> #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates TypeScript from version 5.5.4 to 5.9.2 and changes all Uint8Array type annotations to Uint8Array<ArrayBuffer> throughout the encryption-related modules to improve type specificity and compatibility.
- TypeScript version upgrade across package configurations
- Consistent type annotation changes for binary data handling
- Runtime conversions added to maintain compatibility with existing Buffer usage
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| schemaregistry/rules/encryption/tink/validators.ts | Updated function parameter type annotation |
| schemaregistry/rules/encryption/tink/random.ts | Updated return type annotation |
| schemaregistry/rules/encryption/tink/mac.ts | Updated abstract method signatures |
| schemaregistry/rules/encryption/tink/hmac.ts | Updated method signatures and parameter types |
| schemaregistry/rules/encryption/tink/hkdf.ts | Updated function parameter and return types |
| schemaregistry/rules/encryption/tink/bytes.ts | Updated utility function signatures |
| schemaregistry/rules/encryption/tink/aes_siv.ts | Updated class constructor and method signatures |
| schemaregistry/rules/encryption/tink/aes_gcm.ts | Updated method signatures |
| schemaregistry/rules/encryption/tink/aead.ts | Updated abstract method signatures |
| schemaregistry/rules/encryption/encrypt-executor.ts | Updated static property, method signatures, and added runtime conversions |
| schemaregistry/package.json | Upgraded TypeScript version |
| package.json | Upgraded TypeScript version |
| examples/typescript/package.json | Upgraded TypeScript version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
emasab
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the repository from TypeScript 5.6 to 5.9.
TypeScript 5.9 includes breaking changes to lib.d.ts, forcing us to change some types for some functions from
Uint8ArraytoUint8Array<ArrayBuffer>.The rationale for this change in TypeScript is explained in microsoft/TypeScript#59417: Some APIs accept typed arrays backed by a SharedArrayBuffer, while others only accept ArrayBuffer, and the new version of TypeScript checks the types.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups