Fix email verification input #6367
Conversation
|
@rohit9625 I couldn't find any changes requested for this PR. Could you kindly recheck and let me know which PR you made the changes to? |
This comment was marked as resolved.
This comment was marked as resolved.
|
@rohit9625 you'll have to hit the submit review button for us to see the comments 😅 It's still in pending state, you'll have to open the files tab again to submit. |
What? I thought I just need to comment on it and the pending was showing because no-one has responded to that comment. My bad, I'm really sorry for this :( |
|
No worries, Rohit. It's not very intuitive, maybe. Thanks a lot for reviewing!
We have the add single comment option for that. Start review helps add multiple comments and post all of them in one go. You'll be able to edit/delete the comments before you submit. I can see the comment now. @Kota-Jagadeesh you should also be able see the review comment. |
Yep, thanks :) |
yeah, i am able to see the comments now :) |
…leLine with maxLines=1
…leLine with maxLines=1
…leLine with maxLines=1
|
Working as expected. Good job! @Kota-Jagadeesh After_Email_OTP_Field_Fix.webmHowever, the keyboard gets hidden automatically when the email verification code input field automatically focused or by pressing the IME action at the password input field. This behavior was already there and not a regression. If you don't mind, could you please look for the cause of this issue? I think it'll be a small fix, probably by changing the IME action of the password input field. After that, we can safely merge this PR :) |
|
@rohit9625 Updated the PR , Please review it !! |
|
✅ Generated APK variants! |
|
@rohit9625 If you are free , Can you please review the PR ? |
There was a problem hiding this comment.
It behaves as expected and looks good now. This PR is ready to merge @nicolas-raoul
ReproAfterLoginScreenFix.mp4
|
Thanks a lot @rohit9625 for your in-depth review, and @Kota-Jagadeesh for your contribution! 🙂 |
|
closes #6348 |
LoginActivity.ktto handle IME_ACTION_DONE inaskUserForTwoFactorAuth, ensuringperformLoginis triggered correctly.activity_login.xml,layout-land/activity_login.xml, andlayout-xlarge/activity_login.xmlto setimeOptionstoactionDoneand enforcesingleLineto prevent height expansion.