Skip image upload to Wikidata (nearby -> green pins) #6349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pictures with "Is this a pic of X?" not added to its P18 anymore, that's great! I saw a message like "Failed to update Wikidata" once though... that should not happen right? |
|
✅ Generated APK variants! |
|
I’ve pushed the latest changes — could you please review them when convenient? |
nicolas-raoul
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
The current implementation always attempts to upload images to Wikidata, even when the item already has an image (P18 property).
Fixes #6185
What changes did you make and why?
Modified makeWikiDataEdit() to:
-Check wikiDataPlace.imageValue.isNullOrBlank() before uploading
-Skip the upload if an image already exists
Tests performed (required)
Tested {build variant, ProdDebug} on {name of device or emulator} with API level {API level}.