Fix/kubernetes devcontainer template to require fewer updates on initial deployment #386
+23
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it auth and fixed container security context which will always need to be privileged on majority of K8S deployments
…pu parameter icon reference
Comment on lines
+358
to
+373
| # Note: May not work on AWS Linux Nodes | ||
| # metadata { | ||
| # display_name = "CPU Usage" | ||
| # key = "0_cpu_usage" | ||
| # script = "coder stat cpu" | ||
| # interval = 10 | ||
| # timeout = 1 | ||
| # } | ||
| # Note: May not work on AWS Linux Nodes | ||
| # metadata { | ||
| # display_name = "RAM Usage" | ||
| # key = "1_ram_usage" | ||
| # script = "coder stat mem" | ||
| # interval = 10 | ||
| # timeout = 1 | ||
| # } |
There was a problem hiding this comment.
Suggested change
| # Note: May not work on AWS Linux Nodes | |
| # metadata { | |
| # display_name = "CPU Usage" | |
| # key = "0_cpu_usage" | |
| # script = "coder stat cpu" | |
| # interval = 10 | |
| # timeout = 1 | |
| # } | |
| # Note: May not work on AWS Linux Nodes | |
| # metadata { | |
| # display_name = "RAM Usage" | |
| # key = "1_ram_usage" | |
| # script = "coder stat mem" | |
| # interval = 10 | |
| # timeout = 1 | |
| # } | |
| # Note: May not work on AWS Linux Nodes | |
| metadata { | |
| display_name = "CPU Usage" | |
| key = "0_cpu_usage" | |
| script = "coder stat cpu" | |
| interval = 10 | |
| timeout = 1 | |
| } | |
| # Note: May not work on AWS Linux Nodes | |
| metadata { | |
| display_name = "RAM Usage" | |
| key = "1_ram_usage" | |
| script = "coder stat mem" | |
| interval = 10 | |
| timeout = 1 | |
| } |
@greg-the-coder Would it maybe be worth just adding the Note and leaving the stats. Since not all people would be using kubernetes with aws?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Identified changes to template so that it can be used "out of the box" with fewer updates across a wider variety of coder deployments. Tested on base AWS EKS cluster that used AWS Linux/Bottlerocket node group.
Type of Change
Testing & Validation
bun test)bun run fmt)Related Issues
None