Skip to content

fix: correct remote file picker dropdown chevron alignment #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: correct remote file picker dropdown chevron alignment #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,18 @@ struct FilePickerEntry: View {
} label: {
Label {
Text(entry.name)
ZStack {
CircularProgressView(value: nil, strokeWidth: 2, diameter: 10)
.opacity(entry.isLoading && entry.error == nil ? 1 : 0)
Image(systemName: "exclamationmark.triangle.fill")
.opacity(entry.error != nil ? 1 : 0)
}
// The NSView within the CircularProgressView breaks
// the chevron alignment within the DisclosureGroup view.
// So, we overlay the progressview with a manual offset
.padding(.trailing, 20)
.overlay(alignment: .trailing) {
ZStack {
CircularProgressView(value: nil, strokeWidth: 2, diameter: 10)
.opacity(entry.isLoading && entry.error == nil ? 1 : 0)
Image(systemName: "exclamationmark.triangle.fill")
.opacity(entry.error != nil ? 1 : 0)
}
}
} icon: {
Image(systemName: "folder")
}.help(entry.error != nil ? entry.error!.description : entry.absolute_path)
Expand Down
Loading