Skip to content

chore: Add golangci-lint and codecov #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 5, 2022
Merged

chore: Add golangci-lint and codecov #3

merged 6 commits into from
Jan 5, 2022
+324 −3

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jan 4, 2022 •
edited
Loading

  • Roughly copies .golangci.yml with some additional linting rules.
  • Adds codecov.yml (pending integration).
  • Adds .vscode/settings.json to run tests in the editor as files are saved. This is somewhat a force-function for us devs to write fast tests, and is helpful for increasing coverage!

image

@kylecarbs kylecarbs requested a review from bryphe-coder January 4, 2022 15:56
@kylecarbs kylecarbs self-assigned this Jan 4, 2022
bryphe-coder
bryphe-coder approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🎉

This is somewhat a force-function for us devs to write fast tests, and is helpful for increasing coverage!

Love it

@kylecarbs kylecarbs merged commit a6b2dd7 into main Jan 5, 2022
@kylecarbs kylecarbs deleted the codequality branch January 5, 2022 14:48
@aslilac aslilac mentioned this pull request Jul 23, 2024
Merged
@Emyrk Emyrk mentioned this pull request Oct 22, 2024
Closed
BrunoQuaresma added a commit that referenced this pull request May 8, 2025
@BrunoQuaresma
chore: replce MUI icons #3
6b82662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bryphe-coder bryphe-coder bryphe-coder approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @bryphe-coder