refactor: replace task prompt by workspace name in the topbar #19531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Aug 25, 2025
| @@ -30,21 +37,71 @@ export const TaskTopbar: FC<TaskTopbarProps> = ({ task }) => { | |||
| </Tooltip> | |||
| </TooltipProvider> | |||
|
|
|||
| <h1 className="m-0 text-base font-medium truncate">{task.prompt}</h1> | |||
| <h1 className="m-0 ml-2 text-base font-medium truncate"> | |||
There was a problem hiding this comment.
I think that technically it won't be a huge deal, but could we swap the ml-2 for pl-2? That would reduce the risk of CSS styling side effects
| </RouterLink> | ||
| </Button> | ||
| <div className="ml-auto gap-2 flex items-center"> | ||
| <TooltipProvider delayDuration={0}> |
There was a problem hiding this comment.
Do we want the duration to be set so aggressively low? Radix's default value is 700ms
Comment on lines
+88
to
+106
| return ( | ||
| <Button | ||
| disabled={showCopiedSuccess} | ||
| onClick={copyToClipboard} | ||
| size="sm" | ||
| variant="subtle" | ||
| className="p-0 min-w-0" | ||
| > | ||
| {showCopiedSuccess ? ( | ||
| <> | ||
| <CheckIcon /> Copied! | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <CopyIcon /> Copy | ||
| </> | ||
| )} | ||
| </Button> | ||
| ); |
There was a problem hiding this comment.
In isolation, I think this is perfectly fine, but do we want to centralize the implementation for this, so we can make sure the UI stays more consistent?
I'm seeing a few other buttons in the codebase that are wired up very similarly (making a call to useClipboard, using the CheckIcon and CopyIcon components), and I'm just worried about them drifting over time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19524
Screenshot:
Demo:
Screen.Recording.2025-08-25.at.14.59.15.mov
Changes: