feat(cli): add coder exp tasks list #19496
Merged
+474
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4310e5d to
b269f85
Compare
c1a203d to
ea4b615
Compare
5d1bd5b to
5d0a8cc
Compare
mafredri
commented
Aug 25, 2025
| r.Route("/{user}", func(r chi.Router) { | ||
| r.Use(httpmw.ExtractOrganizationMembersParam(options.Database, api.HTTPAuth.Authorize)) | ||
|
|
||
| r.Get("/", api.tasksList) |
There was a problem hiding this comment.
Review: This path was not conducive to listing other members tasks (e.g. owner).
Note: I don't think it is, but would appreciate validation if the above httpmw is needed for the list endpoint.
There was a problem hiding this comment.
I don't see httpmw.OrganizationMemberParam in use in coderd/aitasks.go so I think you're good 👍
5d0a8cc to
5665d32
Compare
5665d32 to
9a5f639
Compare
johnstcn
approved these changes
Aug 25, 2025
cli/exp_tasklist.go
Outdated
| type taskListRow struct { | ||
| Task codersdk.Task `table:"t,recursive_inline"` | ||
|
|
||
| StateChanged string `table:"state changed"` |
There was a problem hiding this comment.
Nit: suggest naming StateChangedAt or similar so that the semantics are clearer
There was a problem hiding this comment.
Since this is relative, how about StateChangeAgo?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#892
Fixes coder/internal#896
Example output: