>DO NOT MERGE< use ory/fosite to implment oauth2 server #19476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Aug 21, 2025
Comment on lines
28
to
29
| // TODO: Remove the memory store entirely and implement all methods to use the database. | ||
| storage.MemoryStore |
There was a problem hiding this comment.
I think this is a good use-case for our idea of a separate OAuthStore as opposed to just throwing in a database.Store.
There was a problem hiding this comment.
Agreed. I fully intend to minimize the surface area of the db required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial draft of using a library to be an oauth server, rather than implementing ourselves.
Using an in memory store for access tokens atm, and using our oauth apps.
Using
setup-test-app.shandtest-manual-flow.shto verify it works.Screencast.From.2025-08-21.11-57-07.webm
Obviously a lot of work to still do.