chore(coderd/database/dbauthz): migrate the Notifications and Prebuilds tests to use mocked DB #19302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c20f829 to
78eafa2
Compare
bf65b40 to
31de126
Compare
- Replace Subtest with Mocked and set gomock expectations - Use testutil.Fake + gofakeit to generate data - Add necessary GetInboxNotificationByID expectation for read-status updates - Keeps RBAC assertions identical; suite passes locally with GOCACHE
- Replace Subtest with Mocked and add gomock expectations - Mock underlying calls used by querier (e.g., GetTemplateVersionByID, GetPresetByID, GetTemplateByID) - Preserve RBAC assertions and expected returns/errors - Verified by running TestMethodTestSuite/TestPrebuilds locally with GOCACHE
31de126 to
3dd08e2
Compare
78eafa2 to
4dfcb32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to coder/internal#869