Skip to content

feat(cli): add enterprise external-workspaces CLI command #19287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 19, 2025
Merged

feat(cli): add enterprise external-workspaces CLI command #19287

merged 4 commits into from
Aug 19, 2025

Conversation

kacpersaw
Copy link
Contributor

@kacpersaw kacpersaw commented Aug 11, 2025 •
edited
Loading

This pull request introduces support for external workspace management, allowing users to register and manage workspaces that are provisioned and managed outside of the Coder.

  • coder external-workspaces create - Creates a new external workspace (this command extends coder create)
    • Example: coder external-workspaces create ext-workspace --template=externally-managed-workspace -y
    • Checks if template has coder_external_agent resource before creating a workspace
  • coder external-workspaces list - Lists all external workspaces
  • coder external-workspaces agent-instructions - Retrieves agent connection instruction
    • Example: coder external-workspaces agent-instructions ext-workspace main --output=json

@kacpersaw kacpersaw mentioned this pull request Aug 11, 2025
Merged
@kacpersaw Graphite App
Copy link
Contributor Author

kacpersaw commented Aug 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 11, 2025
Merged
Merged
Closed
@kacpersaw kacpersaw changed the title feat(cli): add external-workspaces CLI command to create, list and manage external workspaces feat(cli): add external-workspaces CLI command Aug 11, 2025
@kacpersaw kacpersaw changed the title feat(cli): add external-workspaces CLI command feat(cli): add enterprise external-workspaces CLI command Aug 11, 2025
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-cli branch from 1d9ad42 to 2b42673 Compare August 11, 2025 15:40
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from b641ffe to 07a9c42 Compare August 11, 2025 15:40
@kacpersaw kacpersaw marked this pull request as ready for review August 12, 2025 06:43
@kacpersaw kacpersaw requested a review from deansheather August 12, 2025 06:44
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-cli branch 2 times, most recently from 039892b to e1fd6e8 Compare August 12, 2025 12:44
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from 60cccc2 to 0cf5381 Compare August 12, 2025 12:44
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-cli branch from e1fd6e8 to e7e9376 Compare August 12, 2025 13:13
deansheather
deansheather approved these changes Aug 13, 2025
View reviewed changes
cli/create.go
@@ -29,7 +29,12 @@ const PresetNone = "none"

var ErrNoPresetFound = xerrors.New("no preset found")

func (r *RootCmd) create() *serpent.Command {
type CreateOptions struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should put a comment here explaining what these are for. E.g. "CreateOptions provides middleware for the workspace creation command so it can be extended for other create commands."

@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-cli branch 2 times, most recently from d36771a to cec9a8d Compare August 13, 2025 10:06
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from 4e94ed6 to 5a0bf15 Compare August 13, 2025 10:42
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-cli branch 2 times, most recently from ac11687 to 515fd53 Compare August 13, 2025 12:08
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from 5a0bf15 to ed93d09 Compare August 13, 2025 12:08
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-cli branch 3 times, most recently from d5f8141 to ae3f780 Compare August 18, 2025 12:52
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from bcd7ad2 to c143ef7 Compare August 18, 2025 12:52
@kacpersaw Graphite App
Copy link
Contributor Author

kacpersaw commented Aug 19, 2025 •
edited
Loading

Merge activity

  • Aug 19, 8:29 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 19, 8:43 AM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 19, 8:52 AM UTC: @kacpersaw merged this pull request with Graphite.

@kacpersaw kacpersaw changed the base branch from kacpersaw/feat-coder-attach-api to graphite-base/19287 August 19, 2025 08:30
@kacpersaw kacpersaw changed the base branch from graphite-base/19287 to main August 19, 2025 08:41
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-cli branch from ae3f780 to 9bd7ae5 Compare August 19, 2025 08:42
@kacpersaw kacpersaw merged commit 7b1dcd9 into main Aug 19, 2025
34 checks passed
@kacpersaw kacpersaw deleted the kacpersaw/feat-coder-attach-cli branch August 19, 2025 08:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2025
johnstcn
johnstcn reviewed Aug 19, 2025
View reviewed changes
enterprise/cli/externalworkspaces_test.go
pty.ExpectMatch("export CODER_AGENT_TOKEN=")
pty.ExpectMatch("curl -fsSL")

<-doneChan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See testutil/chan.go for some helpful methods here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn left review comments

@deansheather deansheather deansheather approved these changes

@aslilac aslilac Awaiting requested review from aslilac

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@kacpersaw kacpersaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kacpersaw @johnstcn @deansheather