Skip to content

chore(coderd/provisionerdserver): remove dangerous usage of dbtestutil.DisableForeignKeysAndTriggers #19122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

chore(coderd/provisionerdserver): remove dangerous usage of dbtestutil.DisableForeignKeysAndTriggers #19122

merged 1 commit into from
Aug 4, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Aug 2, 2025

May have caught #18776

@johnstcn johnstcn self-assigned this Aug 2, 2025
Emyrk
Emyrk approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ideally we remove this everywhere incrementally. Maybe we should add a linter to catch new additions?

@johnstcn johnstcn merged commit b0ba798 into main Aug 4, 2025
50 of 54 checks passed
@johnstcn johnstcn deleted the cj/chore/provisionerdserver-no-disable-foreign-key-checks branch August 4, 2025 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

@Emyrk Emyrk Emyrk approved these changes

@dannykopping dannykopping Awaiting requested review from dannykopping

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @spikecurtis @Emyrk