Skip to content

fix(site): only attempt to watch containers when agent connected #18873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

fix(site): only attempt to watch containers when agent connected #18873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions site/src/modules/resources/useAgentContainers.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,4 +193,22 @@ describe("useAgentContainers", () => {
displayErrorSpy.mockRestore();
watchAgentContainersSpy.mockRestore();
});

it("does not establish WebSocket connection when agent is not connected", () => {
const watchAgentContainersSpy = jest.spyOn(API, "watchAgentContainers");

const disconnectedAgent = {
...MockWorkspaceAgent,
status: "disconnected" as const,
};

const { result } = renderHook(() => useAgentContainers(disconnectedAgent), {
wrapper: createWrapper(),
});

expect(watchAgentContainersSpy).not.toHaveBeenCalled();
expect(result.current).toBeUndefined();

watchAgentContainersSpy.mockRestore();
});
});
6 changes: 5 additions & 1 deletion site/src/modules/resources/useAgentContainers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ export function useAgentContainers(
);

useEffect(() => {
if (agent.status !== "connected") {
return;
}

const socket = watchAgentContainers(agent.id);

socket.addEventListener("message", (event) => {
Expand All @@ -53,7 +57,7 @@ export function useAgentContainers(
});

return () => socket.close();
}, [agent.id, updateDevcontainersCache]);
}, [agent.id, agent.status, updateDevcontainersCache]);

return devcontainers;
}
Loading