Skip to content

chore: fix flake in TestWorkspaceBuildsProvisionerState #18839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

chore: fix flake in TestWorkspaceBuildsProvisionerState #18839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions coderd/workspacebuilds_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,14 @@ func TestWorkspaceBuildsProvisionerState(t *testing.T) {
require.NoError(t, err)
coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, build.ID)

// Validate that the deletion was audited.
require.True(t, auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
}))
// Validate that the deletion was audited. This happens after the transaction
// is committed, so it may not show up in the mock auditor immediately.
testutil.Eventually(ctx, t, func(context.Context) bool {
return auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
})
}, testutil.IntervalFast)
})

t.Run("NoProvisioners", func(t *testing.T) {
Expand Down Expand Up @@ -535,11 +538,14 @@ func TestWorkspaceBuildsProvisionerState(t *testing.T) {
require.Empty(t, ws)
require.Equal(t, http.StatusGone, coderdtest.SDKError(t, err).StatusCode())

// Validate that the deletion was audited.
require.True(t, auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
}))
// Validate that the deletion was audited. This happens after the transaction
// is committed, so it may not show up in the mock auditor immediately.
testutil.Eventually(ctx, t, func(context.Context) bool {
return auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
})
}, testutil.IntervalFast)
})
})
}
Expand Down
Loading