Skip to content

fix: handle sql/driver.Valuer types properly in json logs #18760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix: handle sql/driver.Valuer types properly in json logs #18760

merged 1 commit into from
Jul 7, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jul 7, 2025 •
edited
Loading

This bumps slog to incorporate coder/slog#219.

Before:

{
  "fields": {
      "Code": "{Int32:0 Valid:false}",
      "ValidCode": "{Int32:12 Valid:true}"
  }
}

After:

{
  "fields": {
      "Code": null,
      "ValidCode": 12
  }
}

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review July 7, 2025 03:18
@ethanndickson ethanndickson force-pushed the ethan/handle-sql-json-logs branch from c5f1649 to 2a1ff45 Compare July 7, 2025 03:22
@ethanndickson ethanndickson merged commit a1c77e3 into main Jul 7, 2025
30 checks passed
@ethanndickson Graphite App
Copy link
Member Author

Merge activity

@ethanndickson ethanndickson deleted the ethan/handle-sql-json-logs branch July 7, 2025 03:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @deansheather