Skip to content

ci: check go versions are consistent #17149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

ci: check go versions are consistent #17149

merged 3 commits into from
Apr 1, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 28, 2025 •
edited
Loading

Fixes #17063

I'm ignoring flake.nix for now.

$ IGNORE_NIX=true ./scripts/check_go_versions.sh
INFO : go.mod                   : 1.24.1
INFO : dogfood/coder/Dockerfile : 1.24.1
INFO : setup-go/action.yaml     : 1.24.1
INFO : flake.nix                : 1.22
INFO : Ignoring flake.nix, as IGNORE_NIX=true
Go version check passed, all versions are 1.24.1

$ ./scripts/check_go_versions.sh
INFO : go.mod                   : 1.24.1
INFO : dogfood/coder/Dockerfile : 1.24.1
INFO : setup-go/action.yaml     : 1.24.1
INFO : flake.nix                : 1.22
ERROR: Go version mismatch between go.mod and flake.nix

@johnstcn johnstcn requested a review from spikecurtis March 28, 2025 13:34
@johnstcn johnstcn self-assigned this Mar 28, 2025
spikecurtis
spikecurtis approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnstcn johnstcn merged commit cc733ab into main Apr 1, 2025
33 checks passed
@johnstcn johnstcn deleted the cj/ci/check-go-version branch April 1, 2025 08:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: keep go versions in sync
2 participants
@johnstcn @spikecurtis