Skip to content

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 20, 2025

Fixes: #14824

This PR changes the validation message to make it easier to comprehend:

Screenshot 2025-02-20 at 11 47 40

Notice: some edge cases may be confusing:

Screenshot 2025-02-20 at 11 48 01 (- is unsupported)

Screenshot 2025-02-20 at 11 48 19 (but now it is supported?)

@mtojek mtojek self-assigned this Feb 20, 2025
@mtojek mtojek marked this pull request as ready for review February 20, 2025 10:52
@mtojek mtojek requested a review from chrifro February 20, 2025 10:52
Copy link

@chrifro chrifro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mtojek

@mtojek mtojek merged commit f670559 into main Feb 20, 2025
32 of 34 checks passed
@mtojek mtojek deleted the 14824-chars branch February 20, 2025 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise error message for workspace name
2 participants