fix!: enforce regex for agent names #16641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underscores and double hyphens are now blocked. The regex is almost the exact same as the `coder_app` `slug` regex, but uppercase characters are still permitted.
ethanndickson
approved these changes
Feb 20, 2025
Comment on lines
+219
to
+221
| if tfResource.Name == "" { | ||
| return nil, xerrors.Errorf("agent name cannot be empty") | ||
| } |
There was a problem hiding this comment.
This is technically already checked for us by Terraform, but I think it's fine to check again?
There was a problem hiding this comment.
I guess in case we ever change how we extract the name it's good to have
|
@ethanndickson @stirby, we need to call this out in the changelog. |
|
Yep, this and #16614 are both annotated with the breaking tag |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underscores and trailing, leading and double hyphens are now blocked. The regex is almost the exact same as the
coder_appslugregex, but uppercase characters are still permitted.