Skip to content

fix(ui): changed hot keys for helphub #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix(ui): changed hot keys for helphub #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc01df6
changed hot keys for helphub
alinashklyar Jun 17, 2024
4fc8f16
changed text on input buttons
alinashklyar Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/docs-navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<img src="{{site.baseurl}}/images/icons/search.png" />
<span class="ml-2">Search</span>
</div>
<span class="helpbub-toggler--hotkey">&#8984; + K</span>
<span class="helpbub-toggler--hotkey">Ctrl / &#8984; + K</span>
</button>
{% endif %}
</header>
4 changes: 3 additions & 1 deletion _includes/scripts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@
);

document.addEventListener("keydown", function (event) {
if (event.metaKey && event.key === "k") {
const isMac = navigator.userAgent.includes('Mac');
if ((event.key === "k") && ((isMac && event.metaKey) || (!isMac && event.ctrlKey))) {
event.preventDefault();
window.CommandBar.openHelpHub();
setTimeout(() => {
document.querySelector('input[data-testid=helphub-input]').focus()
Expand Down
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <h2 class="mb-3 bd-text-white text-uppercase">
<img src="{{site.baseurl}}/images/icons/search.png" />
<span class="ml-2">Search</span>
</div>
<span class="helpbub-toggler--hotkey">&#8984; + K</span>
<span class="helpbub-toggler--hotkey">Ctrl / &#8984; + K</span>
</button>
<!-- <div>
<form class="bd-search bd-search--home d-flex mt-1 mb-3 mt-md-0 order-2 order-md-2 align-items-center">
Expand Down