Updated Auto-Redirect Flow for Segments #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinashklyar
reviewed
Jun 9, 2025
_includes/scripts.html
Outdated
| @@ -59,8 +59,7 @@ | |||
| <!-- End of Doc Search Embed Code --> | |||
|
|
|||
| <script> | |||
| const isEnterpriseDocumentationCookieSet = document.cookie.includes('cfdoctype=enterprise') | |||
| const commandbarSegment = isEnterpriseDocumentationCookieSet ? '3033bf7f' : '43836ac3' | |||
| const commandbarSegment = IS_ENTERPRISE_DOC_COOKIE_SET ? '3033bf7f' : '43836ac3' | |||
There was a problem hiding this comment.
do we still have this cookie?
There was a problem hiding this comment.
I didn't rename it IS_GITOPS_DOC_COOKIE_SET - thank you!
alinashklyar
reviewed
Jun 9, 2025
| } | ||
|
|
||
| async function handleRedirect() { | ||
| if (shouldSkipRedirect()) return; |
There was a problem hiding this comment.
if gitops cookie is removed, but user is trying to reach gitops page, we will not redirect him to enterprise?
There was a problem hiding this comment.
At this stage, we will maintain a one-way redirect and extend it if necessary.
alinashklyar
approved these changes
Jun 9, 2025
|
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-29569/docs/" |
|
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-29569/docs/" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.