Prepare for tooling API #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds an EDN version of the Clojurephant model, for use by Gradle's tooling API. The plan is to leverage this in the new clojurephant-tooling library, which will provider ways to start various tasks, e.g. clojurescript builds and repls.
There was a mistake in the new logic for putting source on the REPL classpath, that meant a project using both Clojure and ClojureScript plugins would only end up with one on the classpath. This new behavior delays evaluation of which source to include and is now safe for both plugins to be applied.
Only when we are sending the options over to the compiler should we quote them. We don't want the EDN we send to the tooling API to include the quote.
Provides more detail to the tooling API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers a number of small changes needed to support the tooling API library.
Related issues:
Contributor Checklist
patch:if the change added no new functionality and is backwards compatibleminor:if the change added new functionality and is backwards compatiblemajor:if the change is not backwards compatiblechore:if the change doesn't affect plugin logic/behavior at all (and obviously still backwards compatible)patch(clojurescript):)builddocsclojureclojurescriptcommonreplclojurephant-plugin/src/compatTest)docs/)./gradlew check)TIP: If troubleshooting a CI failure, look for the build scan URL in the workflow run summary.