minor(cider): Support jack-in of dependencies #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editor integrations, such as Cider and Calva (maybe others), rely on being able to inject dependencies when starting nREPL in order to ensure they have all of the capabilities their editors use.
Eventually, this could be supported natively by Gradle via [1], but this has been a long-nagging issue with Gradle that made for a poorer user experience than Leiningen, Boot, tools.deps, etc.
Since this is just a Gradle property, it can be provided by editors even if the project isn't using Clojurephant (or the right version of Clojurephant), meaning a graceful degradation to the old experience of requiring the user to have put the right deps on the nREPL classpath.
[1] gradle/gradle#17251
This fixes Clojurephant's side of #78.
Related issues:
Contributor Checklist
patch:
if the change added no new functionality and is backwards compatibleminor:
if the change added new functionality and is backwards compatiblemajor:
if the change is not backwards compatiblechore:
if the change doesn't affect plugin logic/behavior at all (and obviously still backwards compatible)patch(clojurescript):
)build
docs
clojure
clojurescript
common
repl
clojurephant-plugin/src/compatTest
)docs/
)./gradlew check
)TIP: If troubleshooting a CI failure, look for the build scan URL in the workflow run summary.