Unify injected print-method implementations with orchard.print #935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that orchard.print has more printers for different classes, we can use it instead of custom code in cider-nrepl to modify
print-method
behavior. Brings more consistency and removes some code too.One controversial change: different derefables like atoms, futures, etc., have changed how they look:
I hope this doesn't break anything – if people rely on printed representation of these objects, specifically on how cider-nrepl augments them, and then parse that, they are probably in a bigger trouble already.