Skip to content

Fixing broken image links #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing broken image links #481

wants to merge 2 commits into from

Conversation

shrayasr
Copy link

The images for 4-25_making-a-window.asciidoc are referenced from a said images/ folder that is non existent. These are now fixed by using images from the same directory.

One small problem would be that in this example

(def f (frame :title "Lyrical Clojure"))
(show! f)

We say that the title is set to "Lyrical Clojure" but the image shows "Cooki...". Doesn't make TOO much of a difference for sure, just a nitpick.

Also thanks so much for this. I've learnt a lot over the past week.

Cheers. 🍺

@shrayasr
Copy link
Author

Note: Since the fix-image branch doesn't exist on your side, the images aren't being displayed in the rich diff. You can see it working on my fork

@shrayasr
Copy link
Author

Update: Noticed a broken link in another doc as well, fixed it.

@qtrfeast
Copy link
Member

The images/folder is actually an artifact of O'Reilly's manuscript preparation process. Ideally, we'd fix the broken images by getting the links to the images/ folder to work.

@shrayasr
Copy link
Author

Oh I see. Should I make an images folder and move the files there?
On Jul 24, 2015 12:32 AM, "Ryan Neufeld" notifications@github.com wrote:

The images/folder is actually an artifact of O'Reilly's manuscript
preparation process. Ideally, we'd fix the broken images by getting the
links to the images/ folder to work.

—
Reply to this email directly or view it on GitHub
#481 (comment)
.

@qtrfeast
Copy link
Member

They should already be present in /images

@shrayasr
Copy link
Author

Ah they are. Sorry about this. Seems like I didn't study the structure enough. Please feel free to close this PR.

However I have one subsequent question. For anyone trying to read this online, its hard to understand and gives the impression of broken links (like it did for me). Do you think we can fix this in anyway?

Also, thanks for the clarification. 👍. Appreciate it.

@qtrfeast
Copy link
Member

There must be some way to fix the images online. I was hoping there was some way to correct the broken path in the links to point at the correct place.

@tirkarthi tirkarthi mentioned this pull request Sep 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrayasr @qtrfeast