feat(localizations): Add Japanese translations for waitlist and resticted access #6616
Conversation
…icted access - Add translations for signUp.restrictedAccess section - Add translations for waitlist.start and waitlist.success sections - Improve Japanese localization coverage for signup restrictions and waitlist flow 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
|
@hideokamoto is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughIn packages/localizations/src/ja-JP.ts, previously undefined localization fields were populated with Japanese strings. Updated sections include restrictedAccess (actionLink, actionText, blockButton__emailSupport, blockButton__joinWaitlist, subtitle, subtitleWaitlist, title) and waitlist.start (actionLink, actionText, formButton, subtitle, title) plus waitlist.success (message, subtitle, title). No changes to exports or public APIs; all edits are UI text assignments within a single file. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/localizations/src/ja-JP.ts (4)
779-788: Unify “ウェイトリスト” terminology and polish phrasing
- In this file, “ウェイトリスト” is already used at Line 692 (
signIn.start.actionLink__join_waitlist). New strings here use “待機リスト”, which creates inconsistency. Also, “アクセス権限” is slightly stiffer than the more idiomatic “アクセス権”.Apply:
signUp: { restrictedAccess: { actionLink: 'サインイン', actionText: '既にアカウントをお持ちですか？', blockButton__emailSupport: 'サポートに連絡', - blockButton__joinWaitlist: '待機リストに参加', + blockButton__joinWaitlist: 'ウェイトリストに登録', subtitle: - '現在サインアップは無効になっています。アクセス権限があると思われる場合は、サポートまでご連絡ください。', + '現在サインアップは無効になっています。アクセス権があると思われる場合は、サポートまでご連絡ください。', subtitleWaitlist: - '現在サインアップは無効になっています。リリース時に最初に通知を受け取るには、待機リストにご参加ください。', + '現在サインアップは無効になっています。公開時にいち早く通知を受け取るには、ウェイトリストにご登録ください。', title: 'アクセス制限', },
1275-1280: Match waitlist.start copy to existing in-file usage (“ウェイトリスト”)Keep tone; just align the noun and button label with prior usage.
waitlist: { start: { actionLink: 'サインイン', actionText: '既にアクセス権をお持ちですか？', - formButton: '待機リストに参加', + formButton: 'ウェイトリストに登録', - subtitle: 'メールアドレスを入力していただければ、準備が整い次第お知らせいたします', - title: '待機リストに参加', + subtitle: 'メールアドレスをご入力いただければ、準備が整い次第お知らせします', + title: 'ウェイトリストに登録', },Note: The subtitle tweak is optional; it’s slightly more concise/polished. If you prefer the original, keep it and only change the noun.
1282-1285: Consistency for redirect message and titleElsewhere in this file “まもなくリダイレクトされます” (no ellipsis; kana “まもなく”) is used. Also align the title with “ウェイトリスト/ご登録” and consider avoiding “！” for JP UI strings for consistency with nearby titles.
success: { - message: '間もなくリダイレクトされます...', + message: 'まもなくリダイレクトされます', subtitle: '準備が整い次第ご連絡いたします', - title: '待機リストへの参加ありがとうございます！', + title: 'ウェイトリストへのご登録ありがとうございます', },
1274-1286: Add a lightweight regression test for new JA keysNo tests were added. Adding a simple keys-presence test catches accidental removals/renames across locales.
Happy to draft a small Jest/Vitest test that imports
jaJPand asserts the presence/non-empty values of:
- signUp.restrictedAccess.{actionLink,actionText,blockButton__emailSupport,blockButton__joinWaitlist,subtitle,subtitleWaitlist,title}
- waitlist.start.{actionLink,actionText,formButton,subtitle,title}
- waitlist.success.{message,subtitle,title}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/localizations/src/ja-JP.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/ja-JP.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/ja-JP.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/ja-JP.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/ja-JP.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Preferreadonlyfor properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertionsfor literal types:as const
Usesatisfiesoperator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noanytypes without justification
Proper error handling with typed errors
Consistent use ofreadonlyfor immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/ja-JP.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/ja-JP.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/ja-JP.ts
**/*
⚙️ CodeRabbit configuration file
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
packages/localizations/src/ja-JP.ts
**/localizations/**/*.ts
⚙️ CodeRabbit configuration file
**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:
- Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
- Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
- Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
- Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
- Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
- Ensure that all keys are unique and that there are no duplicate or conflicting entries.
- If you notice missing translations for new keys, flag them for completion.
Files:
packages/localizations/src/ja-JP.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
packages/localizations/src/ja-JP.ts (1)
779-788: Translations Verified – No Action RequiredI’ve confirmed that all keys in the
signUp.restrictedAccessblock (ja-JP.ts lines 779–788) and in thewaitlistblock (ja-JP.ts lines 1275–1285) exactly match those defined inpackages/localizations/src/en-US.ts. The intended semantics for both the “restricted access” and “waitlist” flows are preserved in the Japanese translations. No missing or mismatched keys were found.
Description
This PR adds missing Japanese translations for
waitlist functionality and restricted access
scenarios in the
@clerk/localizationspackage.Changes included:
Japanese translations for restricted signup access
messages, including action buttons and descriptive
text
Full Japanese translations for the entire waitlist
user flow
Translation details:
restrictedAccess.actionLink: "サインイン" (SignIn)
restrictedAccess.blockButton__emailSupport:"サポートに連絡" (Contact Support)
restrictedAccess.blockButton__joinWaitlist:"待機リストに参加" (Join Waitlist)
restrictedAccess.subtitle: Explains signuprestrictions and support contact
restrictedAccess.subtitleWaitlist: Explainswaitlist signup for early access
waitlist.start.*: Complete start flowtranslations including form labels and descriptions
waitlist.success.*: Success state translationswith redirect messaging
These translations improve the Japanese localization
coverage for user signup restrictions and waitlist
functionality, providing a better user experience
for Japanese users.
Testing:
localization patterns
Japanese users
Checklist
pnpm testruns as expected.pnpm buildruns as expected.or updated for any package exports
Type of change
documentation
Summary by CodeRabbit