chore(shared): removed unused function #6601
Merged
+5
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0cf967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/fluffy-spiders-grab.md (1)
5-6: Enrich the change note with migration guidance (or clarify internal-only).Add a brief rationale and migration path for consumers. If this is internal-only cleanup, call that out to reassure users.
Option A — Public removal (recommended if Line 2 becomes major):
-Removed unused generateUuid utility +BREAKING: Removed generateUuid export from @clerk/shared. + +Migration: +- Prefer the Web Crypto API: `crypto.randomUUID()` (Node 18+/modern browsers). +- Or use `uuid` package: `import { v4 as uuidv4 } from 'uuid'; uuidv4();` + +Rationale: the internal helper was redundant with standard APIs.Option B — Internal-only (keep patch):
-Removed unused generateUuid utility +Chore: Remove unused internal generateUuid utility (no public API impact). +This symbol was not part of the public surface; consumers do not need to take action.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.changeset/fluffy-spiders-grab.md(1 hunks)packages/shared/src/utils/index.ts(0 hunks)packages/shared/src/utils/uuid.ts(0 hunks)
💤 Files with no reviewable changes (2)
- packages/shared/src/utils/index.ts
- packages/shared/src/utils/uuid.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/fluffy-spiders-grab.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
.changeset/fluffy-spiders-grab.md (2)
1-3: Good: Using Changesets for release automation.The file follows the expected Changesets front-matter format and targets the correct package. No formatting issues detected.
2-2: No public usage or export ofgenerateUuid; patch bump is correctI ran comprehensive ripgrep searches across the monorepo and within the
@clerk/sharedpackage entrypoint and found:
- No imports or references to
generateUuidanywhere in the codebase.- No
exportstatements (public or re-exported) exposinggenerateUuidinpackages/sharedor other modules.Since
generateUuidwas never part of the public API surface, its removal cannot break downstream consumers. The patch-level bump remains appropriate.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
wobsoriano
approved these changes
Aug 21, 2025
tmilewski
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing unused
generateUuidutilityChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Chores
Refactor
Documentation
Note