Skip to content

chore(repo): Upgrade faker to v9 #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

chore(repo): Upgrade faker to v9 #6566

merged 1 commit into from
Aug 18, 2025

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Aug 18, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Updated development dependency @faker-js/faker to v9.9.0 to keep tooling current; no functional impact on the application.
    • Added changeset metadata to support release management and versioning; does not affect runtime behavior or interfaces.
    • No user-facing changes in this release: UI, features, and public APIs remain unchanged.

@panteliselef panteliselef self-assigned this Aug 18, 2025
Copy link

changeset-bot bot commented Aug 18, 2025

🦋 Changeset detected

Latest commit: b3afc82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Aug 18, 2025 2:37pm

Copy link
Contributor

coderabbitai bot commented Aug 18, 2025

📝 Walkthrough

Walkthrough

  • Added .changeset/floppy-rockets-bet.md containing two YAML document separators (“---”) and no other content.
  • Updated devDependency @faker-js/faker in package.json from ^8.1.0 to ^9.9.0.
  • No source code or public API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
package.json (1)

1-169: Ensure lockfile and CI are updated

Since this is a devDependency at the repo root, please make sure:

  • pnpm-lock.yaml is updated and committed.
  • The checklist items (pnpm build/test) are run to catch any test helpers relying on old Faker APIs.

Locally run:

  • pnpm i
  • pnpm test
  • pnpm build
.changeset/floppy-rockets-bet.md (1)

1-2: Add a summary to the empty changeset

The file .changeset/floppy-rockets-bet.md currently has no body content after the second ---. Including a one-line description helps maintainers understand the purpose at a glance.

• Location:

  • .changeset/floppy-rockets-bet.md

Suggested diff:

 ---
 ---
+chore(repo): upgrade @faker-js/faker to v9 (devDependency-only; no package releases)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b5d4242 and b3afc82.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .changeset/floppy-rockets-bet.md (1 hunks)
  • package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • package.json
**/*

⚙️ CodeRabbit Configuration File

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

Files:

  • package.json
.changeset/**

📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/floppy-rockets-bet.md
🪛 LanguageTool
.changeset/floppy-rockets-bet.md

[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: --- ---

(QB_NEW_DE)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
package.json (1)

75-75: Faker v9 upgrade verified: ESM imports and API usage aligned

All code correctly uses named imports (import { faker } from '@faker-js/faker'), with no CommonJS require or default import faker occurrences. API usages in tests and utilities (e.g. faker.person, faker.string, faker.helpers, faker.animal, faker.company) are already updated for v9.

Reminders before merging:

  • Ensure your package.json engines or CI specify Node.js ≥18 and TypeScript ≥5.
  • Confirm your test runners (Jest, Vitest, Playwright, etc.) are configured for ESM modules.
  • Remove any legacy locale-setter calls (e.g. faker.setLocale, .locale) if they remain.

Copy link

pkg-pr-new bot commented Aug 18, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6566

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6566

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6566

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6566

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6566

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6566

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6566

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6566

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6566

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6566

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6566

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6566

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6566

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6566

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6566

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6566

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6566

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6566

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6566

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6566

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6566

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6566

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6566

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6566

commit: b3afc82

Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the upgrade notes, there are no major breaking changes that will affect our code. Approving since we use it only internally 👍🏼

@panteliselef panteliselef merged commit 64f64a1 into main Aug 18, 2025
40 checks passed
@panteliselef panteliselef deleted the elef/upgrade-faker branch August 18, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants