-
Notifications
You must be signed in to change notification settings - Fork 377
chore(repo): Upgrade faker to v9 #6566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b3afc82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthrough
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
package.json (1)
1-169
: Ensure lockfile and CI are updatedSince this is a devDependency at the repo root, please make sure:
- pnpm-lock.yaml is updated and committed.
- The checklist items (pnpm build/test) are run to catch any test helpers relying on old Faker APIs.
Locally run:
- pnpm i
- pnpm test
- pnpm build
.changeset/floppy-rockets-bet.md (1)
1-2
: Add a summary to the empty changesetThe file
.changeset/floppy-rockets-bet.md
currently has no body content after the second---
. Including a one-line description helps maintainers understand the purpose at a glance.• Location:
.changeset/floppy-rockets-bet.md
Suggested diff:
--- --- +chore(repo): upgrade @faker-js/faker to v9 (devDependency-only; no package releases)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
.changeset/floppy-rockets-bet.md
(1 hunks)package.json
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
package.json
**/*
⚙️ CodeRabbit Configuration File
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
package.json
.changeset/**
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/floppy-rockets-bet.md
🪛 LanguageTool
.changeset/floppy-rockets-bet.md
[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: --- ---
(QB_NEW_DE)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: Build Packages
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
package.json (1)
75-75
: Faker v9 upgrade verified: ESM imports and API usage alignedAll code correctly uses named imports (
import { faker } from '@faker-js/faker'
), with no CommonJSrequire
or defaultimport faker
occurrences. API usages in tests and utilities (e.g.faker.person
,faker.string
,faker.helpers
,faker.animal
,faker.company
) are already updated for v9.Reminders before merging:
- Ensure your
package.json
engines or CI specify Node.js ≥18 and TypeScript ≥5.- Confirm your test runners (Jest, Vitest, Playwright, etc.) are configured for ESM modules.
- Remove any legacy locale-setter calls (e.g.
faker.setLocale
,.locale
) if they remain.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the upgrade notes, there are no major breaking changes that will affect our code. Approving since we use it only internally 👍🏼
Description
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit