Guard access to __code__
#387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c4603e to
06dd755
Compare
imjoehaines
referenced
this pull request
May 17, 2024
tomlongridge
approved these changes
May 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We read
__code__when setting a custom delivery object and when sending sessions in order to warn when a custom Delivery implementation doesn't have anoptionsparameterHowever, this breaks when using a
Mockobject as__code__does not exist, nor can it be mockedThis PR adds a guard before reading
__code__so that we avoid a crash if it does not exist. We don't warn in this case as real delivery implementations should always have__code__available, so a warning is likely to be just noise when running testsTesting
Added a unit test using a
Mockobject for delivery